Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oracle8 build #664

Merged
merged 9 commits into from
Jan 11, 2024
Merged

Oracle8 build #664

merged 9 commits into from
Jan 11, 2024

Conversation

JasonMarechal25
Copy link
Contributor

@JasonMarechal25 JasonMarechal25 commented Jul 17, 2023 •
edited
Loading

Add new workflow to build on oracle 8 platform.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@JasonMarechal25 JasonMarechal25 changed the base branch from develop to ci/centos October 17, 2023 14:56
@JasonMarechal25 JasonMarechal25 changed the base branch from ci/centos to develop October 17, 2023 14:57
@JasonMarechal25 JasonMarechal25 force-pushed the ci/oracle_8 branch 2 times, most recently from 68122ed to 7962c7b Compare October 19, 2023 13:53
a-zakir
a-zakir reviewed Oct 26, 2023
View reviewed changes
Copy link
Contributor

@a-zakir a-zakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm ok with this. the branch has to be updated with develop before merge.

@JasonMarechal25 JasonMarechal25 marked this pull request as draft October 31, 2023 13:25
@JasonMarechal25
Copy link
Contributor Author

Need to look into some CI failure

@JasonMarechal25
Copy link
Contributor Author

Blocked by AntaresSimulatorTeam/Antares_Simulator#1741

@JasonMarechal25 JasonMarechal25 changed the title Oracle8 build [Blocked] Oracle8 build Nov 3, 2023
@JasonMarechal25 JasonMarechal25 marked this pull request as ready for review December 20, 2023 14:49
@JasonMarechal25 JasonMarechal25 changed the title [Blocked] Oracle8 build Oracle8 build Dec 20, 2023
a-zakir
a-zakir reviewed Jan 2, 2024
View reviewed changes
.github/workflows/build_oracle8.yml
run: |
dnf install -y epel-release git cmake wget rpm-build redhat-lsb-core openmpi-devel
dnf install -y unzip libuuid-devel boost-test boost-devel gcc-toolset-9-toolchain zlib-devel python3-devel

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the purpose of python3-devel? later on line 86 you installed python3.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

devel version is required to build wheel which is required to pyinstaller

@a-zakir
Copy link
Contributor

a-zakir commented Jan 4, 2024

re-run checks before merge

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@JasonMarechal25 JasonMarechal25 merged commit 67467a7 into develop Jan 11, 2024
25 of 31 checks passed
@JasonMarechal25 JasonMarechal25 deleted the ci/oracle_8 branch January 11, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-zakir a-zakir a-zakir approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonMarechal25 @a-zakir